Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch from cryptonite to crypton #6575

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Switch from cryptonite to crypton #6575

wants to merge 1 commit into from

Conversation

erikd
Copy link
Contributor

@erikd erikd commented Oct 16, 2024

The former is deprecated in favor of the latter which is is drop in replacement. This change also requires a bump in the major version of cardano-crypto-class and related packages from 2.1.* to 2.2.*. No changes are required in Plutus for this change, but cardano-ledger does not currently support 2.2.*.

Pre-submit checklist:

  • Branch
    • Tests are provided (if possible)
    • Commit sequence broadly makes sense
    • Key commits have useful messages
    • Changelog fragments have been written (if appropriate)
    • Relevant tickets are mentioned in commit messages
    • Formatting, PNG optimization, etc. are updated
  • PR
    • (For external contributions) Corresponding issue exists and is linked in the description
    • Targeting master unless this is a cherry-pick backport
    • Self-reviewed the diff
    • Useful pull request description
    • Reviewer requested

@erikd erikd self-assigned this Oct 16, 2024
@erikd erikd marked this pull request as draft October 16, 2024 01:27
@erikd
Copy link
Contributor Author

erikd commented Oct 16, 2024

This PR should not be merged until the two SRPs added in this PR are removed.

erikd
erikd commented Oct 16, 2024
View reviewed changes
plutus-benchmark/plutus-benchmark.cabal
@@ -478,7 +478,7 @@ library marlowe-internal
build-depends:
, base
, bytestring
, cardano-crypto-class >=2.1.5 && <2.3
, cardano-crypto-class
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This constraint here seems superfluous.

erikd
erikd commented Oct 16, 2024
View reviewed changes
plutus-core/plutus-core.cabal
@@ -291,12 +291,12 @@ library
, bytestring
, bytestring-strict-builder
, cardano-crypto
, cardano-crypto-class ^>=2.1.5
, cardano-crypto-class ^>=2.2
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Latest master version of cardano-base

@erikd erikd marked this pull request as ready for review October 22, 2024 05:21
@erikd erikd changed the title WIP: Switch from cryptonite to crypton Switch from cryptonite to crypton Oct 22, 2024
@erikd
Copy link
Contributor Author

erikd commented Oct 22, 2024

This can be merged because this master already contains stuff that breaks cardano-ledger (seems that initUPLCSimplifierTrace has been dropped or moved).

@erikd erikd force-pushed the erikd/crypton branch 2 times, most recently from 899e631 to a4ae768 Compare October 25, 2024 05:38
@erikd
Switch from cryptonite to crypton
e6a0315 
The former is deprecated in favor of the latter which is is drop in
replacement. This change also requires a bump in the major version
of `cardano-crypto-class` and related packages from `2.1.*` to
`2.2.*`. No changes are required in Plutus for this change, but
`cardano-ledger` does not currently support `2.2.*`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@erikd erikd

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@erikd